Don't check both platform_family / os in provides when platform_family will do #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y will do We're already going specific enough here to identify the platform_family. Debian is always going to be on Linux and SmartOS on Solaris2. Don't both checking both. Signed-off-by: Tim Smith <tsmith@chef.io>
|
@lamont-granquist if you have some knowledge of why this is the way it is please drop a knowledge bomb on me |
|
no reason at all. smartos should probably be "platform" its a one-off. although it doesn't matter either way. |
|
Yep I can change that up. All the solaris derivatives just 1:1 match platform and platform_family. |
Signed-off-by: Tim Smith <tsmith@chef.io>
lamont-granquist
approved these changes
Dec 22, 2017
It's the same thing and our tests are constructed in a way that platform_family is necessary here. It's not worth unravelling that to use platform here Signed-off-by: Tim Smith <tsmith@chef.io>
thommay
approved these changes
Jan 3, 2018
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already going specific enough here to identify the platform_family. Debian is always going to be on Linux and SmartOS on Solaris2. Don't both checking both.
Signed-off-by: Tim Smith tsmith@chef.io