Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly print path to config file to the screen in knife configure #7325

Merged
merged 1 commit into from
May 31, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented May 30, 2018

config[:config_file] is the knife.rb path so we'd either make it look like we were writing to a knife.rb file or it was nil and we'd print a blank file path. Toss in some yard and shuffle things around while I'm in here.

Signed-off-by: Tim Smith tsmith@chef.io

config[:config_file] was nil

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested a review from a team May 30, 2018 23:33
@tas50
Copy link
Contributor Author

tas50 commented May 30, 2018

Fixes #7303 #7304

@tas50
Copy link
Contributor Author

tas50 commented May 31, 2018

Proxy tests are broken and unrelated to this change

@tas50 tas50 merged commit bf487b1 into master May 31, 2018
@chef-ci chef-ci deleted the knife_cred_file branch May 31, 2018 00:16
@lock
Copy link

lock bot commented Jul 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants