[SHACK-304] Deprecation checking turns up false positive #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the location string during a deprecation check looks like "/opt/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.3.37/spec/unit/chef_class_spec.rb:141:in `block (4 levels) in <top (required)>'" then trying to catch silence deprecation warnings using only an index number (EG, "Chef::Config[:silence_deprecation_warnings] = [0]") can end up matching part of that location string incorrectly. In this case it matched the 0 in the ruby version. Signed-off-by: tyler-ball <tball@chef.io>
cheeseplus
approved these changes
Jul 31, 2018
tyler-ball
added a commit
to chef-boneyard/chef-dk
that referenced
this pull request
Aug 1, 2018
To take advantage of chef/chef#7515 and fix the build pipeline Signed-off-by: tyler-ball <tball@chef.io>
4 tasks
tyler-ball
added a commit
to chef-boneyard/chef-dk
that referenced
this pull request
Aug 1, 2018
As soon as Chef 14.4 is released and we can consume it we can uncomment these. Chef 14.4 contains chef/chef#7515 which fixes these tests. Signed-off-by: tyler-ball <tball@chef.io>
Merged
4 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the location string during a deprecation check looks like
/opt/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.3.37/spec/unit/chef_class_spec.rb:141:in 'block (4 levels) in <top (required)>'then trying to silencedeprecation warnings using only an index number (EG,
Chef::Config[:silence_deprecation_warnings] = [0]) can end up matchingpart of that location string incorrectly. In this case it matched the 0
in the ruby version.
Issues Resolved
SHACK-304
Check List
Signed-off-by: tyler-ball tball@chef.io