Don't system exit on ohai CriticalPluginFailure #8098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuamiller01
force-pushed
the
critical_ohai_plugin_failure
branch
from
0c99412 to
be9b213
Compare
|
I approve this change in general. BUt you have some test failures. |
Signed-off-by: Joshua Miller <joshmiller@fb.com>
joshuamiller01
force-pushed
the
critical_ohai_plugin_failure
branch
from
be9b213 to
44cc5ce
Compare
|
@lamont - there's a ton of apt failures - doesn't seem related to the PR... am I missing something? |
|
Nevermind a few more retries did it. 👍 for me. @chef/client-maintainers - any thoughts before I merge? |
jaymzh
approved these changes
Jan 10, 2019
|
yeah, rescuing and swallowing the useful error to throw a meaningless one seems like something nobody would really want... |
lamont-granquist
approved these changes
Jan 10, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When critical ohai plugins fail, they currently cause the chef run to
exit(false), which makes the chef run_exception "SystemExit: exit", which isn't very clear as to what actually went wrong.Issues Resolved
By removing the rescue block the run fails with Ohai::Exceptions::CriticalPluginFailure, with a run_exception akin to ""Ohai::Exceptions::CriticalPluginFailure: The following Ohai plugins marked as critical failed: [:BlockDevice]. Failing Chef run."
Check List