Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit locale resource to Linux #8375

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Limit locale resource to Linux #8375

merged 2 commits into from
Apr 16, 2019

Conversation

btm
Copy link
Contributor

@btm btm commented Apr 15, 2019

Platforms that don't use /etc/locale.conf aren't supported

Replaces #8358. Also fixes an intermittent failure on MacOS.

@btm btm requested a review from a team April 15, 2019 21:31
@lamont-granquist
Copy link
Contributor

yeah there we go.

@btm btm force-pushed the btm/locale-fix-custom branch 2 times, most recently from 2827807 to 1ad88d1 Compare April 15, 2019 22:05
@btm
Copy link
Contributor Author

btm commented Apr 15, 2019

Looks like RHEL + friends lack locale-gen and use localedef instead, which we'll need to add support for.

Platforms that don't use /etc/locale.conf aren't supported

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
@btm btm force-pushed the btm/locale-fix-custom branch 2 times, most recently from 0304286 to 7f62eff Compare April 16, 2019 15:18
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
@btm btm force-pushed the btm/locale-fix-custom branch from 1e2c2d5 to c248a1e Compare April 16, 2019 16:09
@btm btm merged commit cd2ade6 into master Apr 16, 2019
@chef-ci chef-ci deleted the btm/locale-fix-custom branch April 16, 2019 18:12
@lock
Copy link

lock bot commented Apr 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants