file: Tell people what file a link is pointing at in warning messages #8417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
force-pushed
the
link_message
branch
2 times, most recently
from
b23f840 to
79ddf11
Compare
|
Looks like realpath isn't going to work on Windows @jaymzh |
|
Fucking Windows. Is there... something that does? |
|
OK I think I added support |
tas50
reviewed
Apr 26, 2019
|
@tas50 so fixing that, at lest running locally the linux stuff, I get a bunch of failures when I do |
jaymzh
force-pushed
the
link_message
branch
3 times, most recently
from
486d447 to
85ba516
Compare
|
OK @tas50 light is green, trap is clean! |
tas50
changed the title
In the event you are managing a file `/etc/file` with a `file` resource, but it turns out to be a link to `/etc/passwd` and you are trying to figure out what overwrite `/etc/passwd`, there is no indication in the logs. Let's add one. Signed-off-by: Phil Dibowitz <phil@ipom.com>
lamont-granquist
approved these changes
May 1, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the event you are managing a file
/etc/filewith afileresource,but it turns out to be a link to
/etc/passwdand you are trying to figureout what overwrite
/etc/passwd, there is no indication in the logs. Let's addone.
Check List