Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_proxy support to the install.ps1 script #298

Closed
wants to merge 1 commit into from
Closed

Add no_proxy support to the install.ps1 script #298

wants to merge 1 commit into from

Conversation

Romascopa
Copy link
Contributor

@Romascopa Romascopa commented Nov 4, 2019

added no_proxy support

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

added no_proxy support
@Romascopa Romascopa requested review from a team as code owners November 4, 2019 21:00
@tas50 tas50 changed the title Update helpers.ps1.erb Add no_proxy support to the install.ps1 script Nov 4, 2019
@Romascopa
Copy link
Contributor Author

I can't get a DCO submitted. The git clone feature isn't working properly for this repo. If I clone and push nothing it wants to delete a ton of files for some reason. Not sure a way around it and don't want to do those deletions. Just the 1 file edit.

@miah
Copy link

miah commented Nov 7, 2019

To submit a DCO, just make sure the last line of your commit includes a sign-off:

[miah@awakening inspec]$ git config -l|grep template
commit.template=~/.config/git/git-commit-template
[miah@awakening inspec]$ 
[miah@awakening inspec]$ cat ~/.config/git/git-commit-template 

Signed-off-by: Miah Johnson <miah@chia-pet.org>

@Romascopa
Copy link
Contributor Author

Romascopa commented Nov 8, 2019 via email

@tas50
Copy link
Contributor

tas50 commented Dec 31, 2019

@Romascopa Any chance you can get the DCO on this one?

@tas50 tas50 added Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. Type: Enhancement Adds new functionality. labels Dec 31, 2019
@tas50
Copy link
Contributor

tas50 commented Dec 31, 2019

Fixed in #299

@tas50 tas50 closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants