Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated powershell template to support airgapped artifact environment… #299

Merged
merged 4 commits into from
Dec 31, 2019

Conversation

Romascopa
Copy link
Contributor

@Romascopa Romascopa commented Nov 5, 2019

…. Will be used by chef_client_updater

Signed-off-by: Lance Robbins lance.robbins@delaware.gov

Description

updated powershell template to support airgapped artifact environment…

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…. Will be used by chef_client_updater

Signed-off-by: Lance Robbins <lance.robbins@delaware.gov>
@Romascopa
Copy link
Contributor Author

Looks like the automated checks have some issues outside of my control. For example a DCO is there.

buildkite doesn't look related to my file edit at all.

@miah
Copy link

miah commented Nov 7, 2019

Looks like the automated checks have some issues outside of my control. For example a DCO is there.

Its because your last commit is missing the sign-off.

Lance Robbins added 2 commits November 8, 2019 08:50
Signed-off-by: Lance Robbins <lance.robbins@delaware.gov>
@Romascopa
Copy link
Contributor Author

sign-off fixed...

@Romascopa
Copy link
Contributor Author

Looks like the pipeline auto-checks have some bugs in them (creating/using filenames that are TOO long). May need to manually push this through.

@tas50 tas50 merged commit 56a250b into chef:master Dec 31, 2019
@tas50
Copy link
Contributor

tas50 commented Dec 31, 2019

Thanks for fixing up the DCO here @Romascopa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants