Enable react/prop-types. (mozilla-services#3977)

.eslintrc.yml

@@ -21,6 +21,7 @@ plugins:
 root: true
 
 rules:
+  consistent-return: off # TODO: remove, and default to mozilla/recommended of "error"
   eqeqeq: off # TODO: change to "error"
   no-console: [error, {allow: [debug, error, info, trace, warn]}]
   no-var: off # TODO: change to "error"

server/src/pages/shotindex/model.js

@@ -8,7 +8,7 @@ exports.createModel = function(req) {
   }
   let serverModel = {
     title,
-    hasDeviceId: req.deviceId || null,
+    hasDeviceId: req.deviceId !== undefined,
     defaultSearch: query || null
   };
   serverModel.shotsPerPage = req.shotsPerPage;

server/src/pages/shotindex/view.js

@@ -276,16 +276,16 @@ Body.propTypes = {
   abTests: PropTypes.object,
   defaultSearch: PropTypes.string,
   disableSearch: PropTypes.bool,
-  downloadUrls: PropTypes.array,
+  downloadUrls: PropTypes.object,
   enableUserSettings: PropTypes.bool,
   hasDeviceId: PropTypes.bool,
   isExtInstalled: PropTypes.bool,
   isOwner: PropTypes.bool,
-  pageNumber: PropTypes.number,
+  pageNumber: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
   shots: PropTypes.array,
-  shotsPerPage: PropTypes.number,
+  shotsPerPage: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
   staticLink: PropTypes.func,
-  totalShots: PropTypes.number
+  totalShots: PropTypes.oneOfType([PropTypes.string, PropTypes.number])
 };
 
 class Card extends React.Component {

server/src/reactruntime.js

@@ -64,7 +64,7 @@ exports.HeadTemplate.propTypes = {
   hashAnalytics: PropTypes.bool,
   messages: PropTypes.object,
   noAnalytics: PropTypes.bool,
-  sentryPublicDSN: PropTypes.bool,
+  sentryPublicDSN: PropTypes.string,
   staticLink: PropTypes.func,
   title: PropTypes.string,
   userLocales: PropTypes.array