Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Review all exceptions in .eslintrc.yml #3977

Closed
ianb opened this issue Jan 17, 2018 · 0 comments
Closed

Review all exceptions in .eslintrc.yml #3977

ianb opened this issue Jan 17, 2018 · 0 comments
Assignees
@chenba
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Milestone
Sprint 6 (60-1) 👨🏼‍🚀

Comments

@ianb
Copy link
Contributor

ianb commented Jan 17, 2018

We have a lot of things set to warn of off in .eslintrc.yml. We should discuss whether we should turn any of these on. Since we are using the Mozilla plugin, each exception we have represents something typically Mozilla rules enforce.
@ianb ianb added code Code quality issue, that does not have any outward effect on the product code quality Not a bug, targeted for fixing in 2018 labels Jan 17, 2018
@ghost ghost added this to the Sprint 6 (60-1) 👨🏼‍🚀 milestone Jan 24, 2018
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Remove eslint rules with no effects. (mozilla-services#3977)
c8c8132
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Enable react/prop-types. (mozilla-services#3977)
d4cf6ff
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Enable react/prop-types. (mozilla-services#3977)
7165478
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Enable react/prop-types. (mozilla-services#3977)
51b04ea
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Enable consistent-return. (mozilla-services#3977)
60df2a4
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Remove eslint rules with no effects. (mozilla-services#3977)
46601a8
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Enable react/prop-types. (mozilla-services#3977)
749fcb2
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Enable consistent-return. (mozilla-services#3977)
51c58f6
chenba added a commit to chenba/screenshots that referenced this issue Jan 31, 2018
@chenba
Replace var with let or const. (mozilla-services#3977)
d694b2f
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Replace var with let or const. (mozilla-services#3977)
50bfb69
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Use prefer-const. (mozilla-services#3977)
17a2c61
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Use eqeqeq. (mozilla-services#3977)
cd5e88b
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Use double quotes. (mozilla-services#3977)
04b6c94
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Remove eslint rules with no effects. (mozilla-services#3977)
a01df3d
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Enable react/prop-types. (mozilla-services#3977)
4da0ad0
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Enable consistent-return. (mozilla-services#3977)
b94b303
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Replace var with let or const. (mozilla-services#3977)
7520f8d
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Use prefer-const. (mozilla-services#3977)
c7dfaab
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Use eqeqeq. (mozilla-services#3977)
b8a3faf
chenba added a commit to chenba/screenshots that referenced this issue Feb 1, 2018
@chenba
Use double quotes. (mozilla-services#3977)
16ce8eb
@chenba chenba mentioned this issue Feb 1, 2018
Merged
@chenba chenba self-assigned this Feb 1, 2018
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Remove eslint rules with no effects. (mozilla-services#3977)
40b380b
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Enable react/prop-types. (mozilla-services#3977)
2c96506
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Enable consistent-return. (mozilla-services#3977)
ed632d6
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Replace var with let or const. (mozilla-services#3977)
6824d8b
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Use prefer-const. (mozilla-services#3977)
eefee3d
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Use eqeqeq. (mozilla-services#3977)
35f01a4
chenba added a commit to chenba/screenshots that referenced this issue Feb 2, 2018
@chenba
Use double quotes. (mozilla-services#3977)
2764e9d
@ianb ianb closed this as completed in #4049 Feb 8, 2018
This was referenced Feb 28, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Projects
None yet
Milestone
Sprint 6 (60-1) 👨🏼‍🚀
Development

No branches or pull requests
2 participants
@ianb @chenba