Add support for Python 3.9 and fix deprecation warning #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning is shown:
```
/opt/appuser/.local/lib/python3.9/site-packages/pyhocon/config_parser.py:4: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
-- Docs: https://docs.pytest.org/en/stable/warnings.html
```
`imp.find_module()` (https://docs.python.org/3/library/imp.html#imp.find_module) was
deprecated since version 3.3.
However Pyhocon has no support for Python 3.3. We can use the alternative function
`importlib.util.find_spec()` (https://docs.python.org/3/library/importlib.html#importlib.util.find_spec)
which was added in Python 3.4 as advised in the docs.
See:chimpler#248
1 similar comment
|
Can we merge this in please? |
|
Any update on this, please? |
|
Thank you @olii! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is compatible with Python 3.9. I just enabled the tests in Tox and added a classifier string.
The second improvement is a fix for: #248