Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.9 and fix deprecation warning #254

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Add support for Python 3.9 and fix deprecation warning #254

merged 2 commits into from
Jul 11, 2021

Commits on Mar 4, 2021

  1. Add compatibility for Python 3.9.

    @olii
    olii committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    e3f234b View commit details
    Browse the repository at this point in the history

  2. Fix deprecation warning with newer Pythons and 'imp' library. 

    This warning is shown:
```
/opt/appuser/.local/lib/python3.9/site-packages/pyhocon/config_parser.py:4: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

-- Docs: https://docs.pytest.org/en/stable/warnings.html
```

`imp.find_module()` (https://docs.python.org/3/library/imp.html#imp.find_module) was
deprecated since version 3.3.
However Pyhocon has no support for Python 3.3. We can use the alternative function
`importlib.util.find_spec()` (https://docs.python.org/3/library/importlib.html#importlib.util.find_spec)
which was added in Python 3.4 as advised in the docs.

See:chimpler#248
    @olii
    olii committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5cff474 View commit details
    Browse the repository at this point in the history