D/I suggestName

[adkian-sifive]

Fixes #2366, draft until issue with name sanitization (here) is fixed

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you state the API impact?
• Did you specify the code generation impact?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• new feature/API

API Impact

Adds suggestName API for hierarchy instances

Backend Code Generation Impact

Desired Merge Strategy

• Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

TODO

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels?
• Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you mark as Please Merge?

[mwachs5]

can you show a test with two different things that are not the same Definition, Instance which also name conflict and successfully sanitize?

val inst0 = Module(new AddOne()).suggestName("potato")
val inst1 = Instance(definition).suggestName("potato")