Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instance.suggestName (backport #2886) #3724

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2024

This is an automatic backport of pull request #2886 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com


Original PR Body

Status: instance names are colliding, causing the new tests 11.3 and 11.4 to fail. Need to figure that out and fix it.

This supersedes #2414, which I think is abandoned. Resolves #2366.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature/API

API Impact

Adds suggestName API for hierarchy instances.

Backend Code Generation Impact

Allows users to control Verilog module instance names.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Adds suggestName API for hierarchy instances.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jan 10, 2024
Copy link

linux-foundation-easycla bot commented Jan 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jackkoenig / name: Jack Koenig (c9b1bae)

@github-actions github-actions bot added the Feature New feature, will be included in release notes label Jan 10, 2024
Co-authored-by: Aditya Naik <aditya.naik@sifive.com>
Co-authored-by: Tynan McAuley <tynan@niobiummicrosystems.com>
(cherry picked from commit 24de2f2)
@mergify mergify bot merged commit 213f89f into 5.x Jan 12, 2024
17 checks passed
@mergify mergify bot deleted the mergify/bp/5.x/pr-2886 branch January 12, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant