Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit implicit clock warnings for SyncReadMem.readWrite when explicit clocks are used #3313

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Don't emit implicit clock warnings for SyncReadMem.readWrite when explicit clocks are used #3313

merged 1 commit into from
Jun 1, 2023

Conversation

jared-barocsi
Copy link
Contributor

Fixes a bug where calling SyncReadMem.readWrite with an explicit Clock that is different from the memory's clock raises an implicit clock warning anyways, when this shouldn't be the case.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jared-barocsi jared-barocsi added the Bugfix Fixes a bug, will be included in release notes label May 31, 2023
@jackkoenig jackkoenig added this to the 3.6.x milestone Jun 1, 2023
jackkoenig
jackkoenig approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jackkoenig jackkoenig merged commit 9e39201 into main Jun 1, 2023
@jackkoenig jackkoenig deleted the mem-readwrite-fix-clock-warning branch June 1, 2023 19:01
@mergify mergify bot added the Backported This PR has been backported label Jun 1, 2023
mergify bot pushed a commit that referenced this pull request Jun 1, 2023
@jared-barocsi @mergify
Don't emit implicit clock warnings when an explicit clock is used (#3313
ee69a00 
)

(cherry picked from commit 9e39201)

# Conflicts:
#	core/src/main/scala/chisel3/Mem.scala
mergify bot pushed a commit that referenced this pull request Jun 1, 2023
@jared-barocsi @mergify
Don't emit implicit clock warnings when an explicit clock is used (#3313
e6ef93d 
)

(cherry picked from commit 9e39201)
This was referenced Jun 1, 2023
Merged
Merged
mergify bot added a commit that referenced this pull request Jun 1, 2023
@mergify @jared-barocsi
Don't emit implicit clock warnings when an explicit clock is used (#3313
5531b29 
) (#3316)

(cherry picked from commit 9e39201)

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jun 1, 2023
@mergify @jared-barocsi @jackkoenig
Don't emit implicit clock warnings for SyncReadMem.readWrite when e…
e9e140d 
…xplicit clocks are used (backport #3313) (#3315)

* Don't emit implicit clock warnings when an explicit clock is used (#3313)

(cherry picked from commit 9e39201)

# Conflicts:
#	core/src/main/scala/chisel3/Mem.scala

* Resolve backport conflicts

---------

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request Jun 20, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jared-barocsi @jackkoenig @jardhu