Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic intrinsic expressions and statements. #3986

Merged

Conversation

dtzSiFive
Copy link
Member

@dtzSiFive dtzSiFive commented Apr 11, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Intrinsic expressions and statements are now supported, streamlining their use. These should be preferred over intrinsicModule's, which in the future will be deprecated and removed.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This does make "user-defined nodes" of Param still start with
"parameter " which seems appropriate.
@dtzSiFive
Copy link
Member Author

dtzSiFive commented Apr 11, 2024

FWIW, example moving SizeOf from intmodule to intrinsic expression: dtzSiFive@3bdab7c
(slightly tweaked things but same idea as shown there 👍)

@dtzSiFive dtzSiFive added the Feature New feature, will be included in release notes label Apr 11, 2024
@dtzSiFive dtzSiFive force-pushed the feature/firrtl-intrinsic-expr-stmt branch from d21a2ae to ab541f8 Compare April 11, 2024 15:53
@dtzSiFive dtzSiFive marked this pull request as ready for review April 11, 2024 15:57
@jackkoenig jackkoenig added this to the 7.0 milestone Apr 11, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great, see comments, especially the one about Map and ordering.

core/src/main/scala/chisel3/Intrinsic.scala Outdated Show resolved Hide resolved
firrtl/src/main/scala/firrtl/ir/IR.scala Show resolved Hide resolved
firrtl/src/main/scala/firrtl/ir/Serializer.scala Outdated Show resolved Hide resolved
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll leave it to your judgement on the API being Map + sorting vs. ordered (but at least note the sorting in the ScalaDoc if that's your decision). Also see minor comment about ScalaDoc style.

@dtzSiFive dtzSiFive merged commit 069a138 into chipsalliance:main Apr 17, 2024
15 checks passed
@dtzSiFive dtzSiFive deleted the feature/firrtl-intrinsic-expr-stmt branch April 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants