-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generic intrinsic expressions and statements. #3986
Add support for generic intrinsic expressions and statements. #3986
Conversation
This does make "user-defined nodes" of Param still start with "parameter " which seems appropriate.
FWIW, example moving SizeOf from intmodule to intrinsic expression: dtzSiFive@3bdab7c |
d21a2ae
to
ab541f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great, see comments, especially the one about Map
and ordering.
Per reviewer feedback, thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll leave it to your judgement on the API being Map + sorting vs. ordered (but at least note the sorting in the ScalaDoc if that's your decision). Also see minor comment about ScalaDoc style.
Per review feedback, thanks!
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Intrinsic expressions and statements are now supported, streamlining their use. These should be preferred over intrinsicModule's, which in the future will be deprecated and removed.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.