Use intrinsic expressions for most intrinsics #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
added
the
Backend Code Generation
jackkoenig
reviewed
Apr 17, 2024
| inst.in := input | ||
| inst.en := enable | ||
| inst.out | ||
| IntrinsicExpr("circt_clock_gate", Clock())(input, enable) | ||
| } |
There was a problem hiding this comment.
Beautiful diff on this file, and it creates less FIRRTL too! 💯
Preserve old interface but mark deprecated.
dtzSiFive
force-pushed
the
feature/use-intrinsic-expressions
branch
from
196f526
to
888ba06
Compare
jackkoenig
approved these changes
Apr 17, 2024
Much better, per reviewer feedback. Thanks!
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
* SizeOf: Use intrinsic expression instead of IntrinsicModule. * mux2cell, mux4cell: Use intrinsic expression. * isX: use intrinsic expression. * PlusArgsValue: use intrinsic expression * PlusArgsTest: IntrinsicExpr, drop unused type argument. Preserve old interface but mark deprecated. * clock gate: use intrinsic expression. * tests: split out FIRRTL generation test from compile check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #3986 , moving most of the current intrinsics to the new intrinsic expressions.
The LTL intrinsics are not migrated in this PR.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Change intrinsic wrappers to use intrinsic expressions instead of intrinsic modules.
PlusArgsTest(x, str)is now deprecated as first argument is unused. UsePlusArgsTest(str).Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.