Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVSim] Fixed non-firing AssertProperty in SVSim (backport #4087) #4088

Merged
merged 2 commits into from
May 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 23, 2024

AssertProperty was failing to fire when used in simulation with verilator. This was due to a missing --assert flag that the simulator (stupidly) requires to support assertions.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

  • [SVSim] Fixed AssertProperty failing to fire in verilator simulation.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4087 done by [Mergify](https://mergify.com).

(cherry picked from commit d3ab477)

# Conflicts:
#	src/test/scala/chiselTests/LTLSpec.scala
#	svsim/src/main/scala/verilator/Backend.scala
@mergify mergify bot added Backport Automated backport, please consider for minor release bp-conflict labels May 23, 2024
Copy link
Contributor Author

mergify bot commented May 23, 2024

Cherry-pick of d3ab477 has failed:

On branch mergify/bp/5.x/pr-4087
Your branch is up to date with 'origin/5.x'.

You are currently cherry-picking commit d3ab477e0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   src/test/scala/chiselTests/LTLSpec.scala
	both modified:   svsim/src/main/scala/verilator/Backend.scala

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label May 23, 2024
@chiselbot chiselbot merged commit e30ff6d into 5.x May 23, 2024
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/5.x/pr-4087 branch May 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants