Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of Github actions to versions using Node 20 #4116

Merged
merged 1 commit into from
May 30, 2024

Conversation

jackkoenig
Copy link
Contributor

Node 16 is deprecated and will eventually stop being supported.

We get lots of warnings, this should fix most of them. The one that remains is The following actions uses node12 which is deprecated and will be forced to run on node16: jodersky/setup-mill@v0.3.0.. That action hasn't been updated in 2 years. We should probably just switch to including the mill wrapper script in tree which is what most projects using mill do12.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Footnotes

  1. https://github.com/Virtuslab/scala-cli

  2. https://github.com/coursier/coursier

@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label May 30, 2024
@jackkoenig jackkoenig added this to the 5.x milestone May 30, 2024
Node 16 is deprecated and will eventually stop being supported.
@jackkoenig jackkoenig merged commit 99aa9f1 into main May 30, 2024
15 checks passed
@jackkoenig jackkoenig deleted the bump-actions-versions branch May 30, 2024 18:00
@mergify mergify bot added the Backported This PR has been backported label May 30, 2024
mergify bot pushed a commit that referenced this pull request May 30, 2024
Node 16 is deprecated and will eventually stop being supported.

(cherry picked from commit 99aa9f1)

# Conflicts:
#	.github/workflows/build-scala-cli-example.yml
#	.github/workflows/ci.yml
#	.github/workflows/install-jextract/action.yml
#	.github/workflows/scala-cli-example.yml
#	.github/workflows/test.yml
mergify bot pushed a commit that referenced this pull request May 30, 2024
Node 16 is deprecated and will eventually stop being supported.

(cherry picked from commit 99aa9f1)

# Conflicts:
#	.github/workflows/test.yml
chiselbot pushed a commit that referenced this pull request May 30, 2024
…4116) (#4118)

* Bump versions of Github actions to versions using Node 20 (#4116)

Node 16 is deprecated and will eventually stop being supported.

(cherry picked from commit 99aa9f1)

# Conflicts:
#	.github/workflows/test.yml

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request May 30, 2024
…4116) (#4117)

* Bump versions of Github actions to versions using Node 20 (#4116)

Node 16 is deprecated and will eventually stop being supported.

(cherry picked from commit 99aa9f1)

# Conflicts:
#	.github/workflows/build-scala-cli-example.yml
#	.github/workflows/ci.yml
#	.github/workflows/install-jextract/action.yml
#	.github/workflows/scala-cli-example.yml
#	.github/workflows/test.yml

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant