Incorporate lessons learned from latest publishing. #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e some settings to common.
…o 3.0-BETA-SNAPSHOT so we can update "in-place".
being lost in Driver.execute before firrtl is called.
# Conflicts: # build.sbt
jackkoenig
reviewed
Sep 20, 2017
build.sbt
Outdated
|
|
||
| // Provide a managed dependency on X if -DXVersion="" is supplied on the command line. | ||
| libraryDependencies ++= (Seq("firrtl").map { | ||
| dep: String => "edu.berkeley.cs" %% dep % sys.props.getOrElse(dep + "Version", defaultVersions(dep)) }), |
There was a problem hiding this comment.
Should this line be tabbed?
There was a problem hiding this comment.
Agree, this should be tabbed
ducky64
requested changes
Sep 22, 2017
build.sbt
Outdated
|
|
||
| // Provide a managed dependency on X if -DXVersion="" is supplied on the command line. | ||
| libraryDependencies ++= (Seq("firrtl").map { | ||
| dep: String => "edu.berkeley.cs" %% dep % sys.props.getOrElse(dep + "Version", defaultVersions(dep)) }), |
There was a problem hiding this comment.
Agree, this should be tabbed
build.sbt
Outdated
|
|
||
| // Provide a managed dependency on X if -DXVersion="" is supplied on the command line. | ||
| libraryDependencies ++= (Seq("firrtl").map { | ||
| dep: String => "edu.berkeley.cs" %% dep % sys.props.getOrElse(dep + "Version", defaultVersions(dep)) }), |
There was a problem hiding this comment.
Can you also merge the dep into the rest of them? Unless you anticipate dependencies on more than just firrtl, that map really isn't doing much.
There was a problem hiding this comment.
Right. It was mostly to preserve style with the other repos where the map includes more/all of the BIG4.
# Conflicts: # build.sbt
# Conflicts: # build.sbt
ducky64
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to sbt incorporated from release branch. This is not strictly required, but is an attempt to keep master and release branches relatively in sync.