Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Set prerequisite of -X high to MinimalHighForm #1704

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Set prerequisite of -X high to MinimalHighForm #1704

merged 1 commit into from
Jun 22, 2020

Conversation

seldridge
Copy link
Member

@seldridge seldridge commented Jun 22, 2020 •
edited
Loading

Change the behavior of running with -X high to cause only MinimalHighForm to be resolved. This result in resolves, checks, and deduplication not running. This restores 1.2.x behavior.

Contributor Checklist

  • [n/a] Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • [nope] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

None.

Backend Code Generation Impact

None.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@seldridge
Set prerequisite of -X high to MinimalHighForm
a9715aa 
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
@seldridge seldridge added this to the 1.3.x milestone Jun 22, 2020
@seldridge seldridge requested a review from a team as a code owner June 22, 2020 22:16
@seldridge seldridge added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 22, 2020
@mergify mergify bot merged commit a845a11 into master Jun 22, 2020
mergify bot pushed a commit that referenced this pull request Jun 22, 2020
@seldridge
Set prerequisite of -X high to MinimalHighForm (#1704)
98d1da6 
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit a845a11)
@mergify mergify bot mentioned this pull request Jun 22, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Jun 22, 2020
@seldridge seldridge deleted the high-emitter-is-MinimalHighForm branch June 22, 2020 22:59
mergify bot added a commit that referenced this pull request Jun 22, 2020
@mergify @seldridge
Set prerequisite of -X high to MinimalHighForm (#1704) (#1705)
0bb00cf 
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit a845a11)

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
@jackkoenig jackkoenig mentioned this pull request Jun 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch bugfix Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
1.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@seldridge @jackkoenig