Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRCI: use RecordMap API to get easier to follow names on clock group signals #2528

Merged
merged 4 commits into from
Jun 26, 2020

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Jun 22, 2020

Related issue:

Redo of #2487 which seems to have rebase issues
Bumps FIRRTL along 1.3.x

This builds on top of #2486 and will be rebased on top of it as that API changes.

This demonstrates the use of the new RecordMap. API to get better names for clock group signals

In the comments I'll include a diff before and after this change.

Type of change:feature request

Impact: API modification

(Generated RTL will have different output)
Also bumps firrtl along 1.3.x branch which notably changes the Dedup behavior (this was a bug before)

Development Phase: implementation

Release Notes

I/O and internal signals in the clock related modules (ClockSource, ClockGroup, etc) will have more meaningful I/O names vs simply indexed names. This also results in less deduplication of ClockGroup-related modules as their names are different.

Firrtl Bump Notes

Feature

Bugfix

Performance

@mwachs5
Copy link
Contributor Author

mwachs5 commented Jun 22, 2020

blocked by chipsalliance/firrtl#1703

@mwachs5 mwachs5 changed the title Prci use heterogeneous bag api PRCI: use RecordMap API to get easier to follow names on clock group signals Jun 24, 2020
@mwachs5 mwachs5 marked this pull request as ready for review June 24, 2020 16:59
@mwachs5 mwachs5 requested review from hcook and jackkoenig June 24, 2020 17:02
@mwachs5 mwachs5 force-pushed the prci-use-heterogeneous-bag-api branch from 7535743 to 1a1446a Compare June 24, 2020 20:49
@mwachs5 mwachs5 changed the base branch from named_heterogeneous_bags to master June 24, 2020 20:50
mwachs5 added 4 commits June 25, 2020 06:05
PRCI: Use RecordListMap.  This compiles but not sure about the foo  in there...

Update src/main/scala/prci/ClockGroup.scala

Use simplified RecordMap instead of hash version

PRCI: tweaks

PRCI: Checkpoint, does not get past FIRRTL

Committing changes to show FIRRTL exception case

PRCI: actually lists of ClockGroupBundles are still heterogenous bags

PRCI: fix naming of the clock group bundle signals

PRCI: try adding a Wire() to get around None.get error

PRCI: add some more Wire()s and debugging statements

ClockGroup: back to chisel3

PRCI: cleanup to minimize diff

ClockGroup: remove unused import
@mwachs5 mwachs5 force-pushed the prci-use-heterogeneous-bag-api branch from 9eb4a74 to c8cdee6 Compare June 25, 2020 13:06
@jackkoenig
Copy link
Contributor

jackkoenig commented Jun 25, 2020

Firrtl Bump Notes

Feature

Bugfix

Performance

@mwachs5
Copy link
Contributor Author

mwachs5 commented Jun 26, 2020

@hcook can I get an approval on this?
(or @jackkoenig ?)

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwachs5 mwachs5 merged commit 8454954 into master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants