-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRCI: use RecordMap API to get easier to follow names on clock group signals #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
blocked by chipsalliance/firrtl#1703 |
mwachs5
changed the title
Prci use heterogeneous bag api
PRCI: use RecordMap API to get easier to follow names on clock group signals
Jun 24, 2020
mwachs5
force-pushed
the
prci-use-heterogeneous-bag-api
branch
from
June 24, 2020 20:49
7535743
to
1a1446a
Compare
PRCI: Use RecordListMap. This compiles but not sure about the foo in there... Update src/main/scala/prci/ClockGroup.scala Use simplified RecordMap instead of hash version PRCI: tweaks PRCI: Checkpoint, does not get past FIRRTL Committing changes to show FIRRTL exception case PRCI: actually lists of ClockGroupBundles are still heterogenous bags PRCI: fix naming of the clock group bundle signals PRCI: try adding a Wire() to get around None.get error PRCI: add some more Wire()s and debugging statements ClockGroup: back to chisel3 PRCI: cleanup to minimize diff ClockGroup: remove unused import
mwachs5
force-pushed
the
prci-use-heterogeneous-bag-api
branch
from
June 25, 2020 13:06
9eb4a74
to
c8cdee6
Compare
@hcook can I get an approval on this? |
jackkoenig
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Redo of #2487 which seems to have rebase issues
Bumps FIRRTL along 1.3.x
This builds on top of #2486 and will be rebased on top of it as that API changes.This demonstrates the use of the new RecordMap. API to get better names for clock group signals
In the comments I'll include a diff before and after this change.
Type of change:feature request
Impact: API modification
(Generated RTL will have different output)
Also bumps firrtl along 1.3.x branch which notably changes the Dedup behavior (this was a bug before)
Development Phase: implementation
Release Notes
I/O and internal signals in the clock related modules (ClockSource, ClockGroup, etc) will have more meaningful I/O names vs simply indexed names. This also results in less deduplication of ClockGroup-related modules as their names are different.
Firrtl Bump Notes
Feature
find_heap_bound.py
(Find Heap Bound firrtl#1648)Block.mapStmt
(Find Heap Bound firrtl#1648)Bugfix
RemoveReset
(Canonicalize init of regs with zero as reset in RemoveReset firrtl#1627)-ll trace
when annotations aren't serializable (Improve anno logging firrtl#1639)1.2.x
meaning of-X high
in CLI (Set prerequisite of -X high to MinimalHighForm firrtl#1704)ValidIf
to ProtoBuf [de]serialization (Add support for ValidIf to ProtoBuf [de]serialization firrtl#1707)Performance