User bits overhaul #2326
Merged
User bits overhaul #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, modulo what we discussed about intersection vs union of the master and slave sides.
|
hcook
approved these changes
Mar 10, 2020
terpstra
force-pushed
the
improved-user-bits
branch
from
4722b7f to
b588c0b
Compare
terpstra
force-pushed
the
user-bits-overhall
branch
2 times, most recently
from
21e3b8a to
fc5761a
Compare
terpstra
force-pushed
the
user-bits-overhall
branch
from
f72ba68 to
7fefa0c
Compare
terpstra
force-pushed
the
user-bits-overhall
branch
from
d7a7267 to
4cb3766
Compare
terpstra
force-pushed
the
user-bits-overhall
branch
from
4cb3766 to
bb28123
Compare
The bridge behaviour before the introduction of AMBAProt: APB pprot = 1 => priv, secure, !fetch AHB hprot = 3 => priv, !fetch, !buffer, !cache AXI4 prot = 1 => priv, secure, !fetch AXI4 cache = 0 => !buffer, !cache, !modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely replace user bits in every rocket-chip diplomatic bus. One application is that we can now carry AMBA-style protection bits between AMBA adapters over a TileLink-based SoC.
Type of change: other enhancement
Impact: API modification
Development Phase: implementation