Improvements To AMBA AXI4 Adapters #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwachs5
reviewed
Oct 22, 2020
mwachs5
reviewed
Oct 22, 2020
mwachs5
reviewed
Oct 22, 2020
jackkoenig
reviewed
Oct 22, 2020
jackkoenig
reviewed
Oct 22, 2020
hcook
force-pushed
the
improve-amba
branch
2 times, most recently
from
29e5035 to
eb6fb17
Compare
|
@jackkoenig @mwachs5 can one of you approve this? |
jackkoenig
reviewed
Oct 26, 2020
| { | ||
| private val axiDigits = String.valueOf(axi4.endId-1).length() | ||
| private val tlDigits = String.valueOf(tl.endSourceId-1).length() | ||
| val tlMasters = tlPort.masters.sortBy(_.sourceId).sortWith(TLToAXI4.sortByType) |
There was a problem hiding this comment.
I was a little confused at first why there are two sorts in a row. It may be worth adding another TLToAXI4.sortBy<something> method to provide the desired behavior. Perhaps sortByType should break ties with sourceId? Just a thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous improvements to several AXI4 AMBA adapters:
TLtoAXI4IdMapTLToAXI4.stripBitsother than 0 illegal and stop using it internally.Annotated.idMappingand delete associated application and annotation class.Type of change:other enhancement
Impact: no API changes
Development Phase: implementation