-
Notifications
You must be signed in to change notification settings - Fork 838
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
ERC721ABatchBurnable
extension (#444)
* added comments on transfer hooks * added sort * added clearApprovalsAndEmitTransferEvent * added tokenBatchTransfer hooks * added _batchTransferFrom and safe variants * added ERC721ABatchTransferable extension and interface * formatting * added interface and ERC721ABatchTransferableMock * added ERC721ABatchTransferable tests (wip) * added approvalCheck * fixed duplicate call * comment * fixed next initialized * refactored lastInitPackedOwnership to use prevPackedOwnership * comments * ensured correctness of nextInitialized in slots of transferred token Ids * renamed variables * reverted to leave nextInitialized unchanged * comment * replace sort -> insertion sort * bump: prettier-plugin-solidity * prettier * added prettier-ignore * fixed nextTokenId in last array element * tests wip * refactor * updated BatchTransferable mock and extension * updated tests * add approval tests * lint * lint fix * restore original .prettierrc * fix * comments and refactor * added _batchBurn * added ERC721ABatchBurnable extension, interfaces and mock * fixed _batchBurn * fixed update of last tokenId + 1 * batchBurnable tests wip * refactor * fix * add auto-clearing of consecutive ids and set `nextInitialized` to false * batchTransfer tests refactor * tests wip * tests wip * comments * added extraData logic to batch mocks * updated batch tests * refactored ERC721A to use _updateTokenId * wip * comment * Add ERC721ABatchBurnableMock (#450) * change tokenIds in ascending order in test * removal of unneeded internal functions * prettier * removed batch transfer logic * changed _updateTokenId * fixed mock * fixed extension and mock * fixed tests and cleaned unused functions in mock * removed _updateTokenId * minor gas optimizations * comment * optimize: avoid potential double read from storage * removed bulkBurn from mock * optimization: reset _packedOwnerships for initialized sequential IDs * added tests for sequential ID clearing * added test for tokenIds in strictly ascending order * comment * optimize: keep track of prevTokenOwner to bypass duplicated logic * revert: resetting _packedOwnerships in initialized sequential IDs * cleanup * optimize: avoid potential double read from storage * optimize: removed unneeded exists() via getApproved
- Loading branch information
Showing
8 changed files
with
599 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,4 @@ | |
} | ||
} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// SPDX-License-Identifier: MIT | ||
// ERC721A Contracts v4.2.3 | ||
// Creator: Chiru Labs | ||
|
||
pragma solidity ^0.8.4; | ||
|
||
import './ERC721ABurnable.sol'; | ||
import './IERC721ABatchBurnable.sol'; | ||
|
||
/** | ||
* @title ERC721ABatchBurnable. | ||
* | ||
* @dev ERC721A token optimized for batch burns. | ||
*/ | ||
abstract contract ERC721ABatchBurnable is ERC721ABurnable, IERC721ABatchBurnable { | ||
function batchBurn(uint256[] memory tokenIds) public virtual override { | ||
_batchBurn(msg.sender, tokenIds, true); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// SPDX-License-Identifier: MIT | ||
// ERC721A Contracts v4.2.3 | ||
// Creator: Chiru Labs | ||
|
||
pragma solidity ^0.8.4; | ||
|
||
import './IERC721ABurnable.sol'; | ||
|
||
/** | ||
* @dev Interface of ERC721ABatchBurnable. | ||
*/ | ||
interface IERC721ABatchBurnable is IERC721ABurnable { | ||
function batchBurn(uint256[] memory tokenIds) external; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// SPDX-License-Identifier: MIT | ||
// ERC721A Contracts v4.2.3 | ||
// Creator: Chiru Labs | ||
|
||
pragma solidity ^0.8.4; | ||
|
||
import '../extensions/IERC721ABatchBurnable.sol'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// SPDX-License-Identifier: MIT | ||
// ERC721A Contracts v4.2.3 | ||
// Creators: Chiru Labs | ||
|
||
pragma solidity ^0.8.4; | ||
|
||
import '../extensions/ERC721ABatchBurnable.sol'; | ||
import './DirectBurnBitSetterHelper.sol'; | ||
|
||
contract ERC721ABatchBurnableMock is ERC721ABatchBurnable, DirectBurnBitSetterHelper { | ||
constructor(string memory name_, string memory symbol_) ERC721A(name_, symbol_) {} | ||
|
||
function exists(uint256 tokenId) public view returns (bool) { | ||
return _exists(tokenId); | ||
} | ||
|
||
function safeMint(address to, uint256 quantity) public { | ||
_safeMint(to, quantity); | ||
} | ||
|
||
function getOwnershipAt(uint256 index) public view returns (TokenOwnership memory) { | ||
return _ownershipAt(index); | ||
} | ||
|
||
function totalMinted() public view returns (uint256) { | ||
return _totalMinted(); | ||
} | ||
|
||
function totalBurned() public view returns (uint256) { | ||
return _totalBurned(); | ||
} | ||
|
||
function numberBurned(address owner) public view returns (uint256) { | ||
return _numberBurned(owner); | ||
} | ||
|
||
function initializeOwnershipAt(uint256 index) public { | ||
_initializeOwnershipAt(index); | ||
} | ||
|
||
function batchBurnUnoptimized(uint256[] memory tokenIds) public { | ||
unchecked { | ||
uint256 tokenId; | ||
for (uint256 i; i < tokenIds.length; ++i) { | ||
tokenId = tokenIds[i]; | ||
_burn(tokenId); | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.