Add ERC721ABatchBurnable extension

[jjranalli]

This PR introduces the ERC721ABatchBurnable extension, leveraging the _batchBurn function introduced here and then refactored in #450.

Assumptions

Some assumptions had to be made:

• Batch operations accept a uint256[] tokenIds param, instead of startTokenId + quantity. This was done to:
  • Allow the function to be used the same way as other common batch burns
  • Allow to operate on non-consecutive tokenIds, thus being less limiting and more practical for the caller
• The tokenIds argument assumes ordered ids
  • It is delegated to the caller making sure that tokenIds are in ascending order.

Notes

• Added minor gas optimizations in _batchBurn
• Added tests for ERC721BatchBurnable

[Vectorized]

O.O Sort.

[Vectorized]

Oh, possible to add in an approvalCheck parameter to the function?

Similar to _burn(tokenId, approvalCheck).

In case someone has a use case for doing batch transfers internally.

[jjranalli]

Oh, possible to add in an approvalCheck parameter to the function?

Absolutely, on it. Just to confirm, it would result in the following functions:

• _batchTransferFrom(from, to, tokenIds)
• _batchTransferFrom(from, to, tokenIds, approvalCheck)
• _safeBatchTransferFrom(from, to, tokenIds)
• _safeBatchTransferFrom(from, to, tokenIds, approvalCheck)
• _safeBatchTransferFrom(from, to, tokenIds, _data)
• _safeBatchTransferFrom(from, to, tokenIds, _data, approvalCheck)

[Vectorized]

@jjranalli Yes!

[jjranalli]

@Vectorized approvalCheck flag added.

Also fixing some issues with the logic. Will push a new version soon

[jjranalli]

The commit above is an attempt to ensure correctness of nextInitialized for all token IDs, while minimizing gas impact.

[Vectorized]

I think the sort can use insertion sort. Then we can add a comment on passing in sorted tokenIds for best performance.
The full intro sort costs several hundred bytes of bytecode.

Thanks so much for the PR.

I’m wondering if we can also do batch burning.

[Nlferu]

Hi @Vectorized

Are there any updates on batchTransferFrom and batchBurn extensions? Any chance those will be included into ERC721A soon?