Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Proxy BypassList value must be a regular expression, in the help output #3401

Closed
2 tasks done
corbob opened this issue Feb 21, 2024 · 1 comment · Fixed by #3414
Closed
2 tasks done

Clarify Proxy BypassList value must be a regular expression, in the help output #3401

corbob opened this issue Feb 21, 2024 · 1 comment · Fixed by #3414

Comments

@corbob
Copy link
Member

corbob commented Feb 21, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

The help text in ConfigurationBuilder.cs should clarify that Proxy.BypassList is a regular expression.

Describe The Solution. Why is it needed?

.Net treats the Proxy configurations Bypass List as a regular expression. In the common parameter we call that out, but we do not call it out for the configuration file settings.

Additional Context

The information can be updated here:

config.Proxy.BypassList = SetConfigItem(ApplicationParameters.ConfigSettings.ProxyBypassList, configFileSettings, string.Empty, "Optional proxy bypass list. Comma separated.");

Related Issues

@corbob corbob self-assigned this Feb 23, 2024
corbob added a commit to corbob/choco that referenced this issue Apr 5, 2024
@gep13 gep13 added this to the 2.3.0 milestone Apr 18, 2024
corbob added a commit to corbob/choco that referenced this issue Apr 19, 2024
vexx32 added a commit that referenced this issue Apr 19, 2024
@pauby pauby changed the title Update help output to reflect that the Proxy BypassList is a regular expression Clarify 'Proxy BypassList' is a regular expression May 28, 2024
@pauby pauby changed the title Clarify 'Proxy BypassList' is a regular expression Clarify 'Proxy BypassList' value must be a regular expression May 28, 2024
@pauby pauby changed the title Clarify 'Proxy BypassList' value must be a regular expression Clarify 'Proxy BypassList' value must be a regular expression, in the help May 28, 2024
@pauby pauby changed the title Clarify 'Proxy BypassList' value must be a regular expression, in the help Clarify 'Proxy BypassList' value must be a regular expression, in the help output May 28, 2024
@gep13 gep13 changed the title Clarify 'Proxy BypassList' value must be a regular expression, in the help output Clarify Proxy BypassList value must be a regular expression, in the help output May 30, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants