Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception if no source is enabled #490

Closed
pascalberger opened this issue Nov 24, 2015 · 6 comments
Closed

Exception if no source is enabled #490

pascalberger opened this issue Nov 24, 2015 · 6 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_LOW Up For Grabs
Milestone
0.9.10

Comments

@pascalberger
Copy link
Contributor

If I have all my sources disabled and try to install a package a null reference exception is thrown:

C:\>choco install nodejs
Installing the following packages:
nodejs
By installing you accept licenses for the packages.
Object reference not set to an instance of an object.

Better would be if the exception is handled and instead an error message is displayed informing the user that no source is available.
@ferventcoder
Copy link
Member

Latest version I assume? I knew about this error, I'm not sure if it is already logged or not.

@ferventcoder
Copy link
Member

It is not yet logged. Thanks!

@ferventcoder ferventcoder added this to the 0.9.10 milestone Nov 24, 2015
@pascalberger
Copy link
Contributor Author

Yes, with 0.9.9.11

@MikeFoden
Copy link
Contributor

I would like to tackle this one.

@ferventcoder
Copy link
Member

@MikeFoden Sweet! Read over the CONTRIBUTING doc to make sure you don't have any issues with the workflow or signing the CLA, then target the stable branch with your changes.

This was referenced Jan 15, 2016
Closed
Closed
@MikeFoden
Copy link
Contributor

@ferventcoder I've put through #547 for this issue.

I didn't do it correctly with #546 so I closed it - sorry! I'm still pretty new at contributing to open source.

ferventcoder pushed a commit that referenced this issue Jan 18, 2016
@MikeFoden @ferventcoder
(GH-490) Exception if no source is enabled
62cd0e0 
Previously if no sources were available during installation of a
package, installation would fail with an exception. This fix will make
the choco client check the source list to make sure it is not null
before attempting to install, update, or list packages.
ferventcoder added a commit that referenced this issue Jan 18, 2016
@ferventcoder
Merge branch 'stable'
9e901cc 
* stable:
  (GH-490) Exception if no source is enabled
@ferventcoder ferventcoder self-assigned this Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_LOW Up For Grabs
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
4 participants
@ferventcoder @MikeFoden @gep13 @pascalberger