(GH-490) Exception if no source is enabled #547
Conversation
Previously if no sources were available during installation of a package, installation would fail with an Exception. This fix will make the choco client check the source list to make sure it is not null before attempting to install a package.
| } | ||
|
|
||
| this.Log().Info(@"By installing you accept licenses for the packages."); | ||
|
|
There was a problem hiding this comment.
I believe this is also necessary for upgrade_run.
|
Please also add a few tests that will show this working properly. That can be done in the install/upgrade scenarios if you want. |
|
Overall 👍 so far! |
There have been messages added for when an attempt to install, update or list a package occurs without any sources being available. Tests have also been added to show the code successfully catches these scenarios.
|
@ferventcoder I have added it in for upgrade and for list, and set up tests for all three to show that if there is no sources available that it will show a message to the user explaining the issue. |
| MockLogger.contains_message("Installation was NOT successful. There are no sources enabled for packages.", LogLevel.Error).ShouldBeTrue(); | ||
| Results.Count().ShouldEqual(0); | ||
| } | ||
| } |
Do we have the ability to fix the exception at the source? |
|
It's anything that references There is a couple of things I can do:
Which one works best for you @ferventcoder? I would assume the scenario that no sources are available would be relatively small as by default the chocolately feed is configured - a user would have to actively play with the configuration to get this situation to occur. |
|
All good - I'll take a look at this and merge it soon. |
|
Thanks for the contribution! |
|
Thanks for helping me get involved! |
|
I fixed up a little and squashed the commits. Thanks again! |
Previously if no sources were available during installation of a
package, installation would fail with an Exception. This fix will make
the choco client check the source list to make sure it is not null
before attempting to install a package.
As per my discussion with @ferventcoder this fixes #490.
The exception itself occurs at
\src\chocolatey\infrastructure.app\services\NugetService.cs:313when checking the source list contains an extension without confirming there is something in the source list first. I've added in a check before showing the licenses to confirm that there is sources defined.This PR supersedes #546.