(#954) Enhance and clarify proxy bypass list documentation #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauby
reviewed
Feb 26, 2024
corbob
commented
Feb 26, 2024
corbob
force-pushed
the
954-enhance-and-clarify-proxy-bypass-list-documentation
branch
from
607b9e9
to
d8432bc
Compare
10 tasks
corbob
force-pushed
the
954-enhance-and-clarify-proxy-bypass-list-documentation
branch
from
d8432bc
to
1a5afdf
Compare
corbob
force-pushed
the
954-enhance-and-clarify-proxy-bypass-list-documentation
branch
2 times, most recently
from
388ef68
to
f41229f
Compare
pauby
requested changes
Apr 25, 2024
corbob
force-pushed
the
954-enhance-and-clarify-proxy-bypass-list-documentation
branch
from
f41229f
to
360f33c
Compare
Clarify that Chocolatey treats the proxy bypass settings as a comma separated list of regular expressions. Update information about certificates used It would seem that packages.chocolatey.org no longer uses the AddTrust certificate, and instead uses the same certificate that community.chocolatey.org uses. This updates the section speaking about these certificates to only include the GoDaddy root certificate. It also clarifies the prior remark about the Thumbnail being incorrect. The GoDaddy repository now lists the column as CHA256 Thumbnails, and it matches the thumbnail presented by Firefox.
Bring the proxy information over from Chocolatey CLI help changes.
The template option on the new command references the Chocolatey CLI build path instead of the default install location. This updates it to reflect the standard installation path.
pauby
force-pushed
the
954-enhance-and-clarify-proxy-bypass-list-documentation
branch
from
360f33c
to
b273ffd
Compare
pauby
approved these changes
Apr 30, 2024
|
Thanks @corbob. I've rebased this and set it to auto-merge when checks are complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Enhance and clarify the proxy bypass list settings.
Additionally clarify the root certificates needed as that data appeared to be outdated.
Motivation and Context
Need to be more clear that the bypass list is a regular expression list and not a globbing list.
Testing
Change Types Made
Change Checklist
Related Issue
Fixes #954