Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inspect script #654

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Fix inspect script #654

merged 1 commit into from
Oct 14, 2018

Conversation

goto-bus-stop
Copy link
Member

discify is a different module than intended. discify is an alternative
to disc that works as a plugin, but we were using it as a separate
command line program. This switches it out for disc. The disc command
line program is called discify which is probably where the confusion
came from.

Also swapped out unassertify and uglifyify for tinyify, which adds tree
shaking.

`discify` is a different module than intended. discify is an alternative
to disc that works as a plugin, but we were using it as a separate
command line program. This switches it out for disc. The disc command
line program is called `discify` which is probably where the confusion
came from.

Also swapped out unassertify and uglifyify for tinyify, which adds tree
shaking.
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goto-bus-stop goto-bus-stop merged commit d6f6ddb into master Oct 14, 2018
@yoshuawuyts yoshuawuyts deleted the fix-inspect branch October 16, 2018 07:59
tornqvist added a commit to tornqvist/choo that referenced this pull request Jun 8, 2019
* master:
  6.13.3
  Revert init order change
  Add browser tests (choojs#696)
  6.13.2
  Fix location missing on store init (choojs#695)
  Typo Fix in Readme (choojs#693)
  6.13.1
  Fix wrong this usage in nanohref integration (choojs#689)
  Some spelling & typo fixes in readme (choojs#688)
  Fix inspect script (choojs#654)
tornqvist added a commit to tornqvist/choo that referenced this pull request Jun 8, 2019
* master: (71 commits)
  6.13.3
  Revert init order change
  Add browser tests (choojs#696)
  6.13.2
  Fix location missing on store init (choojs#695)
  Typo Fix in Readme (choojs#693)
  6.13.1
  Fix wrong this usage in nanohref integration (choojs#689)
  Some spelling & typo fixes in readme (choojs#688)
  Fix inspect script (choojs#654)
  Add v6 tests (choojs#674)
  Remove references to bel (choojs#678)
  6.13.0
  Add hash option (choojs#667)
  Add documentation on components (choojs#673)
  Update README.md (choojs#669)
  6.12.1
  6.12.0
  typings: add app to app.use cb (choojs#665)
  update dependencies (choojs#663)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants