Add v6 tests #674
Merged
Add v6 tests #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added tests for the new component cache. Would it be alright if I push them to this branch? |
|
Up to Tim, but I'm cool with it. We should land these. |
|
Absolutely! |
bcomnes
approved these changes
Jul 31, 2018
|
🎉 |
tornqvist
added a commit
to tornqvist/choo
that referenced
this pull request
Jun 8, 2019
* master: (71 commits) 6.13.3 Revert init order change Add browser tests (choojs#696) 6.13.2 Fix location missing on store init (choojs#695) Typo Fix in Readme (choojs#693) 6.13.1 Fix wrong this usage in nanohref integration (choojs#689) Some spelling & typo fixes in readme (choojs#688) Fix inspect script (choojs#654) Add v6 tests (choojs#674) Remove references to bel (choojs#678) 6.13.0 Add hash option (choojs#667) Add documentation on components (choojs#673) Update README.md (choojs#669) 6.12.1 6.12.0 typings: add app to app.use cb (choojs#665) update dependencies (choojs#663) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #528. I was just going off the features listed in the readme. There are a handful more we should test but this is a start.
Note that this includes a readme change for
state.hrefthat I believe was incorrectly documented. Let me know if I got that wrong.Also note that we should delete the original
v6-testsbranch once this is merged. Leaving it for now for reference.