Show outdated message when new test is available, and disable review button immediately #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3633 Show "Snapshot Outdated" header as soon as we have a new snapshot for the current story
Snapshot outdated - Visual testing in Storybook (Figma) NOTE: We can detect this state if |
…shot-outdated-header-as-soon-as-we-have-a-new
ghengeveld
approved these changes
Sep 11, 2023
…shot-outdated-header-as-soon-as-we-have-a-new
If the `StoryInfo` is already going to prompt you to switch, there's no point in redundantly showing you also in the eyebrow: https://www.chromatic.com/review?appId=6480e1b0042842f149cfd74c&number=87&activeElementId=comment-thread-64ff2a5781851ff6d5e44492
|
@MichaelArestad I accidentally merged this but I was still hoping to resolve this final question: https://www.chromatic.com/review?appId=6480e1b0042842f149cfd74c&number=87&type=linked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to QA
a. Review button should be disabled as soon as second build reaches the "snapshotting" state
b. Header should prompt you to switch stories as soon as the story you are looking at is captured.
📦 Published PR as canary version:
0.0.66--canary.87.fc95b12.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.66--canary.87.fc95b12.0 # or yarn add @chromaui/addon-visual-tests@0.0.66--canary.87.fc95b12.0