Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro to Storybook Spanish translation (React) #693

Merged
merged 43 commits into from
Mar 31, 2023

Conversation

lmac-1
Copy link
Contributor

@lmac-1 lmac-1 commented Feb 27, 2023

As discussed in this issue, I've been working on an updated Spanish translation of the Intro to Storybook tutorial for React over the past month or so. This PR contains a full translation to all screens of the current English Intro to Storybook tutorial.

I have also gone through my updates with my Colombian partner to make sure that it makes sense for him.

Let me know if you have any further questions, or need any further updates.

Thanks!
Lucy

Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmac-1, this looks amazing 🤩. I scanned through it, and it just needs a couple of tweaks and should be good to go on my end to merge. Let me know once you've made the changes, and we'll go from there. Sounds good?

Also, before we forget, can you update this line in your gatsby-config file from 5.3 to 6.5, as this will bump the version of the tutorial to match the current one and will remove the aside at the top of the page.

Comment on lines 64 to 65
// Dar forma a las historias a través de la composición de args.
// Los datos se heredaron de la historia predeterminada en Task.stories.js.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmac-1, if you're able to revert the comments in the snippets back to English throughout your pull request, I'd appreciate it. I'm aware that leaving them in the natural language brings the translation "closer to home" (pardon the bad pun), but it's our guideline to leave them as such. Sorry for not being more explicit with those in the Readme. I completely forgot about it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, will get on it! Perhaps we should add something about this to the original issue that tracks translations (if it's not there already!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in this commit

I made sure all code snippets are equal to the English version, which is why you'll see some extra line breaks added in this commit.

content/intro-to-storybook/react/es/screen.md Outdated Show resolved Hide resolved
@lmac-1
Copy link
Contributor Author

lmac-1 commented Mar 2, 2023

Thanks for going through this @jonniebigodes! I really appreciate your feedback and I'll get on the changes mentioned asap.

I have a slightly "silly" question. I've mainly been making the updates in the GitHub UI but I'd prefer to work on this locally so that I can group changes to multiple files in one commit (for example changing the comments back to English). Normally when I contribute to a project, I check it out locally. This is the largest project I've ever contributed to and when I tried to clone it locally with git clone, it got stuck (I think because of its size). Am I missing something, or is there another way for me to work on the project locally? Thanks!

@jonniebigodes
Copy link
Collaborator

@lmac-1 no need to thank. Glad to help you out in proofreading it. Regarding your question about the repository, can you provide me with a bit more context on what you're experiencing? I'm asking because this repository, in comparison with other ones in the Chromatic org or the Storybook org, is one of the smallest ones, and you should be able to clone it without any issues. Related to this, did you, by any chance, try and fork this repository and tried to clone it locally into your machine?

If you didn't, can you please try and let me know? Also, while we're at it, you might need to grab the documentation folder from the Storybook monorepo, which can be done by running the command yarn extract-sb-docs-metadata after the cloning process is finished and you installed the required dependencies via running yarn. If it doesn't work, please let me know so I can look at it and see what's happening. Sounds good?

Looking forward to hearing from you.

Hope you have a great weekend.

@lmac-1
Copy link
Contributor Author

lmac-1 commented Mar 3, 2023

Previously when I was trying to git clone my fork, my terminal was hanging and getting stuck and wasn't able to finish cloning. Today I've managed to clone the project locally, so I can start working on the final updates 🎉

However, I'm not able to test the changes locally because when I start the development server, it's returning the following JSON in the browser:

{"codeFrame":"No codeFrame could be generated","sourcePosition":null,"sourceContent":null}

When I opened the browser, this is the error that is happening in the terminal:

warn The path "/" errored during SSR.
Edit its component webpack/bootstrap:19:1 to resolve the error.

 ERROR #11615 

There was an error while trying to load dev-404-page:
 Cannot find module '../../../../public/page-data/sq/d/1604654434.json'

File: webpack/bootstrap:19:1

Also higher up in my terminal, there were some other errors after running yarn dev:

ERROR #85923  GRAPHQL

There was an error in your GraphQL query:

Cannot query field "dxData" on type "Query".

If you don't expect "dxData" to exist on the type "Query" it is most
likely a typo. However, if you expect "dxData" to exist there are a
couple of solutions to common problems:

- If you added a new data source and/or changed something inside
gatsby-node/gatsby-config, please try a restart of your development
server.
- You want to optionally use your field "dxData" and right now it is not
used anywhere.

It is recommended to explicitly type your GraphQL schema if you want to
use optional fields.

File: src/components/composite/AppLayout.js:136:7

See our docs page for more info on this error:
https://gatsby.dev/creating-type-definitions


 ERROR #85923  GRAPHQL

There was an error in your GraphQL query:

Cannot query field "dxData" on type "Query".

If you don't expect "dxData" to exist on the type "Query" it is most
likely a typo. However, if you expect "dxData" to exist there are a
couple of solutions to common problems:

- If you added a new data source and/or changed something inside
gatsby-node/gatsby-config, please try a restart of your development
server.
- You want to optionally use your field "dxData" and right now it is not
used anywhere.

It is recommended to explicitly type your GraphQL schema if you want to
use optional fields.

File: src/components/screens/NotFoundScreen/NotFoundScreen.js:22:7

See our docs page for more info on this error:
https://gatsby.dev/creating-type-definitions

failed extract queries from components - 1.457s
success write out requires - 0.062s
success run static queries - 0.112s - 1/1 8.91/s
success run page queries - 0.035s - 3/3 86.03/s
warn Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly:
https://github.com/browserslist/update-db#readme

 ERROR #98124  WEBPACK

Generating development SSR bundle failed

Can't resolve '../../../public/page-data/sq/d/238248339.json' in '/Users/
lucymacartney/Documents/Code/learnstorybook.com/src/components/composite'

If you're trying to use a package make sure that
'../../../public/page-data/sq/d/238248339.json' is installed. If you're
trying to use a local file make sure that the path is correct.

File: src/components/composite/AppLayout.js:3:0


 ERROR #98124  WEBPACK

Generating development SSR bundle failed

Can't resolve '../../../../public/page-data/sq/d/1604654434.json' in
'/Users/lucymacartney/Documents/Code/learnstorybook.com/src/components/sc
reens/NotFoundScreen'

If you're trying to use a package make sure that
'../../../../public/page-data/sq/d/1604654434.json' is installed. If
you're trying to use a local file make sure that the path is correct.

File: src/components/screens/NotFoundScreen/NotFoundScreen.js:1:0

⠀

To clarify, these are the steps that previously followed:

  1. git clone my fork
  2. change branch to spanish-translation-updates
  3. update version in gatsby-config
  4. yarn install
  5. yarn extract-sb-docs-metadata
  6. yarn dev

Let me know if I'm missing a step, or configured something slightly incorrectly

@lmac-1
Copy link
Contributor Author

lmac-1 commented Mar 3, 2023

I've made the updates you mentioned:

  • Updated all code snippets to match English version
  • Updated Gatsby config
  • Removed reference to corredor de prueba
  • Updated README to show that this guide's translation is updated

Would I also be able to add myself as a contributor? 😁 Is that in the overall README file, or is it just in /content/intro-to-storybook/index.md?

@jonniebigodes
Copy link
Collaborator

@lmac-1, thanks for taking the time to address the feedback. I hope you don't mind, but I've reached out to a fellow team member to take a look at this, as she's more fluent in Spanish than I am, and wanted to see if we missed anything regarding the translation. She's currently checking it, and we'll follow up with you based on any potential feedback. With that out of the way, regarding your issue in previewing the documentation, this is something that we're aware of and will address after Storybook 7.0, as we currently don't have the bandwidth to address it. We already pinpointed it, and it's just a matter of addressing the required changes. For contributors like yourself, I will add you later once this is out. I'm planning on updating the issue, calling out for translators to place you in the right slot. Also, the Readme (repository, not the tutorial) will be updated to feature you as a contributor, similar to other recent contributors who helped us. Once the changes are up, I'll let you know. Sounds good?

@lmac-1
Copy link
Contributor Author

lmac-1 commented Mar 8, 2023

Sounds great! No worries about running locally, completely understand. As long as it's all working on your side, that's great!

And yes sounds good about contributors. I noticed that some had links to Twitter, in case you need it it's https://twitter.com/codingwithlucy

Thanks, will keep an eye out for any other feedback! :)

@lmac-1
Copy link
Contributor Author

lmac-1 commented Mar 24, 2023

Hi Jonny, hope things are well with you! I just wanted to check in to ask how the translation review is going? Let me know if you need any other changes done :)

Thanks and have a great day!

Copy link
Collaborator

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmac-1 sorry for the delay and radio silence, but it's been a couple of busy weeks getting stuff ready for 7.0. I've checked in with my fellow team member, and she only had one item that requires attention and one other nice to have so that we're consistent and accurate. Asides from those nothing stood out, and once they're addressed this should be good to be merged.

Let me know once you've applied the changes, and we'll go from there.

Hope you have a fantastic weekend.

Stay safe

content/intro-to-storybook/react/es/using-addons.md Outdated Show resolved Hide resolved
content/intro-to-storybook/react/es/using-addons.md Outdated Show resolved Hide resolved
@lmac-1
Copy link
Contributor Author

lmac-1 commented Mar 24, 2023

Completely understand that these things take time @jonniebigodes, especially when other projects are involved.

I've fixed both of the issues mentioned, so I think we should be good to go. Please thank your colleague for taking the time to review my translations, much appreciated!

Have a great weekend :-)

@jonniebigodes
Copy link
Collaborator

@lmac-1 I've checked, and this is good to go. Thank you so much for addressing the feedback so promptly. I'll merge this one in a bit and get it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants