-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intro to Storybook Spanish translation (React) #693
Intro to Storybook Spanish translation (React) #693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmac-1, this looks amazing 🤩. I scanned through it, and it just needs a couple of tweaks and should be good to go on my end to merge. Let me know once you've made the changes, and we'll go from there. Sounds good?
Also, before we forget, can you update this line in your gatsby-config
file from 5.3 to 6.5, as this will bump the version of the tutorial to match the current one and will remove the aside at the top of the page.
// Dar forma a las historias a través de la composición de args. | ||
// Los datos se heredaron de la historia predeterminada en Task.stories.js. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmac-1, if you're able to revert the comments in the snippets back to English throughout your pull request, I'd appreciate it. I'm aware that leaving them in the natural language brings the translation "closer to home" (pardon the bad pun), but it's our guideline to leave them as such. Sorry for not being more explicit with those in the Readme. I completely forgot about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, will get on it! Perhaps we should add something about this to the original issue that tracks translations (if it's not there already!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in this commit ✅
I made sure all code snippets are equal to the English version, which is why you'll see some extra line breaks added in this commit.
Thanks for going through this @jonniebigodes! I really appreciate your feedback and I'll get on the changes mentioned asap. I have a slightly "silly" question. I've mainly been making the updates in the GitHub UI but I'd prefer to work on this locally so that I can group changes to multiple files in one commit (for example changing the comments back to English). Normally when I contribute to a project, I check it out locally. This is the largest project I've ever contributed to and when I tried to clone it locally with |
@lmac-1 no need to thank. Glad to help you out in proofreading it. Regarding your question about the repository, can you provide me with a bit more context on what you're experiencing? I'm asking because this repository, in comparison with other ones in the Chromatic org or the Storybook org, is one of the smallest ones, and you should be able to clone it without any issues. Related to this, did you, by any chance, try and fork this repository and tried to clone it locally into your machine? If you didn't, can you please try and let me know? Also, while we're at it, you might need to grab the documentation folder from the Storybook monorepo, which can be done by running the command Looking forward to hearing from you. Hope you have a great weekend. |
Previously when I was trying to However, I'm not able to test the changes locally because when I start the development server, it's returning the following JSON in the browser:
When I opened the browser, this is the error that is happening in the terminal:
Also higher up in my terminal, there were some other errors after running
To clarify, these are the steps that previously followed:
Let me know if I'm missing a step, or configured something slightly incorrectly |
I've made the updates you mentioned:
Would I also be able to add myself as a contributor? 😁 Is that in the overall README file, or is it just in |
@lmac-1, thanks for taking the time to address the feedback. I hope you don't mind, but I've reached out to a fellow team member to take a look at this, as she's more fluent in Spanish than I am, and wanted to see if we missed anything regarding the translation. She's currently checking it, and we'll follow up with you based on any potential feedback. With that out of the way, regarding your issue in previewing the documentation, this is something that we're aware of and will address after Storybook 7.0, as we currently don't have the bandwidth to address it. We already pinpointed it, and it's just a matter of addressing the required changes. For contributors like yourself, I will add you later once this is out. I'm planning on updating the issue, calling out for translators to place you in the right slot. Also, the Readme (repository, not the tutorial) will be updated to feature you as a contributor, similar to other recent contributors who helped us. Once the changes are up, I'll let you know. Sounds good? |
Sounds great! No worries about running locally, completely understand. As long as it's all working on your side, that's great! And yes sounds good about contributors. I noticed that some had links to Twitter, in case you need it it's https://twitter.com/codingwithlucy Thanks, will keep an eye out for any other feedback! :) |
Hi Jonny, hope things are well with you! I just wanted to check in to ask how the translation review is going? Let me know if you need any other changes done :) Thanks and have a great day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmac-1 sorry for the delay and radio silence, but it's been a couple of busy weeks getting stuff ready for 7.0. I've checked in with my fellow team member, and she only had one item that requires attention and one other nice to have so that we're consistent and accurate. Asides from those nothing stood out, and once they're addressed this should be good to be merged.
Let me know once you've applied the changes, and we'll go from there.
Hope you have a fantastic weekend.
Stay safe
Completely understand that these things take time @jonniebigodes, especially when other projects are involved. I've fixed both of the issues mentioned, so I think we should be good to go. Please thank your colleague for taking the time to review my translations, much appreciated! Have a great weekend :-) |
@lmac-1 I've checked, and this is good to go. Thank you so much for addressing the feedback so promptly. I'll merge this one in a bit and get it out. |
As discussed in this issue, I've been working on an updated Spanish translation of the Intro to Storybook tutorial for React over the past month or so. This PR contains a full translation to all screens of the current English Intro to Storybook tutorial.
I have also gone through my updates with my Colombian partner to make sure that it makes sense for him.
Let me know if you have any further questions, or need any further updates.
Thanks!
Lucy