Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro to Storybook Spanish translation (React) #775

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

lmac-1
Copy link
Contributor

@lmac-1 lmac-1 commented Sep 9, 2024

Hello again!

I previously translated this tutorial in #693. This PR updates the Spanish translation for the Intro to Storybook tutorial to match the current English version.

If you have any questions or feedback, let me know.

Thanks again and have a great day!

@lmac-1 lmac-1 mentioned this pull request Sep 11, 2024
@jonniebigodes jonniebigodes self-assigned this Sep 18, 2024
@jonniebigodes
Copy link
Collaborator

@lmac-1, thanks for taking the time to update the Spanish translation to match the current version. We appreciate it. If you're ok with it, I'll be more than glad to take a look sometime next week and follow up with you on any feedback; sounds good?

Hope you have an amazing day.

Stay safe

@lmac-1
Copy link
Contributor Author

lmac-1 commented Sep 21, 2024

@jonniebigodes you're welcome. Sounds good to me, whenever you have time :)

Hope you're having a great September!

@jonniebigodes
Copy link
Collaborator

@lmac-1, sorry for the radio silence, but I plan to look into the translation sometime this week so we can get it in. Before doing that, I was wondering if you could adjust it to match the changes in #784 so that we can align this to match the current version.

Looking forward to hearing from you.

Hope you have a great week.

Stay safe

@jonniebigodes
Copy link
Collaborator

@lmac-1 I've checked, and aside from the changes mentioned in #784 that need to be added here, the translation is looking fantastic. I've checked, and all is good so far. I cannot thank you enough for this 🙏 ! Let me know once you've addressed the changes, and I'll take a look. If nothing stands out, I'll get the updated translation published.

Have a great day.

@lmac-1
Copy link
Contributor Author

lmac-1 commented Nov 6, 2024

Hi @jonniebigodes, weirdly enough I was just thinking about this PR today - we must be connected!

I will get on the remaining changes now and update when finished 😌

Thanks!

@lmac-1
Copy link
Contributor Author

lmac-1 commented Nov 6, 2024

Okay I think I've done the minor updates, nice and easy :-)

Should be good to merge once you've given it a quick check but let me know if you need something else.

I'm also working on the Design System translation in a branch and will report back when finished.

Thanks again!

@jonniebigodes
Copy link
Collaborator

@lmac-1, thank you for taking the time to address the feedback so promptly. I appreciate it 🙏 ! I've looked into the changes, and all is good on my end. I'm going to merge it.

Also, it's great to hear you're already working on the Design Systems tutorial. I will look into it and make the adjustments as needed so that you and other fellow translators can get the translation right.

Hope you have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes merged commit 6823a6d into chromaui:master Nov 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants