Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Go version to v1.14.5 #319

Merged
merged 1 commit into from
Jul 17, 2020
Merged

update Go version to v1.14.5 #319

merged 1 commit into from
Jul 17, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Jul 15, 2020

No description provided.

@rolinh
update Go version to v1.14.5
61df957 
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. needs-backport/0.5 This PR needs backporting to the v0.5 branch. needs-backport/0.6 This PR needs backporting to the v0.6 branch. labels Jul 15, 2020
@glibsm
Copy link
Member

glibsm commented Jul 15, 2020

does version in go.mod matter?

@rolinh
Copy link
Member Author

rolinh commented Jul 15, 2020

does version in go.mod matter?

The go directive in the go.mod file indicates the minimum Go version for the project (it defaults to the current version if not specified). So I don't think we want to bump it up unless we have to.

@rolinh rolinh merged commit ca7412c into master Jul 17, 2020
@rolinh rolinh deleted the pr/rolinh/go-1.14.5 branch July 17, 2020 08:02
@rolinh rolinh mentioned this pull request Jul 22, 2020
Merged
@rolinh rolinh added backport-pending/0.5 The backport for Hubble 0.5.x for this PR is in progress. and removed needs-backport/0.5 This PR needs backporting to the v0.5 branch. labels Jul 22, 2020
@rolinh rolinh mentioned this pull request Jul 22, 2020
Merged
@rolinh rolinh added backport-pending/0.6 The backport for Hubble 0.6.x for this PR is in progress. backport-done/0.5 The backport for Hubble 0.5.x for this PR is done. backport-done/0.6 The backport for Hubble 0.6.x for this PR is done. and removed needs-backport/0.6 This PR needs backporting to the v0.6 branch. backport-pending/0.5 The backport for Hubble 0.5.x for this PR is in progress. backport-pending/0.6 The backport for Hubble 0.6.x for this PR is in progress. labels Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. backport-done/0.5 The backport for Hubble 0.5.x for this PR is done. backport-done/0.6 The backport for Hubble 0.6.x for this PR is done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolinh @glibsm @gandro