v0.6 backports 2020-07-22 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rolinh
commented
Jul 22, 2020
rolinh
commented
- update Go version to v1.14.5 #319
- Update Go to v1.14.6 #320
- make: fix release build directory ownership #321
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Before this patch, `make release` would generate the release/ directory (and files underneath) owned by root:root. This is caused by the fact that the build happen as root inside the Docker container. As a result, a following `make clean` from outside the container as an unprivileged user would fail. This patch fix the issue by chowning the release directory and files to the user uid and gid whom invoked make originally (i.e. from outside the container). Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
rolinh
added
🧰 kind/backport
gandro
approved these changes
Jul 22, 2020
michi-covalent
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.