make: set missing IMAGE_TAG variable #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is used to set the tag for the docker image. It is now set
to `latest` if the version string contains `-dev` and to the
`v${VERSION}` otherwise and was previously unassigned leading to always
produce `latest` when building a docker image.
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Co-authored-by: Alexandre Perrin <alex@kaworu.ch>
rolinh
added
🐛 kind/bug
kaworu
approved these changes
Nov 20, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
glibsm
approved these changes
Nov 20, 2020
rolinh
added
backport-pending/0.7
rolinh
added
backport-pending/0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is used to set the tag for the docker image. It is now set to
latestif the version string contains-devand to thev${VERSION}otherwise and was previously unassigned leading to always producelatestwhen building a docker image.