Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6: make: set missing IMAGE_TAG variable #436

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Nov 23, 2020

This is a backport of #432 to the v0.6 branch.

This variable is used to set the tag for the docker image. It is now set
to `latest` if the version string contains `-dev` and to the
`v${VERSION}` otherwise and was previously unassigned leading to always
produce `latest` when building a docker image.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Co-authored-by: Alexandre Perrin <alex@kaworu.ch>
@rolinh rolinh added release-note/misc This PR makes changes that have no direct user impact. 🧰 kind/backport This PR backports changes to a release branch backport/0.6 This PR is a backport for Hubble v0.6. labels Nov 23, 2020
@gandro gandro merged commit 8cf4031 into v0.6 Nov 23, 2020
@gandro gandro deleted the pr/rolinh/v0.6-set-image-tag-var branch November 23, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.6 This PR is a backport for Hubble v0.6. 🧰 kind/backport This PR backports changes to a release branch release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants