This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Store the Docker Compose configuration in this project #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
the
improvement
This moves the Docker Compose configuration out of a `docker-compose.override.yml` file stored in the configuration for the cisagov/client-cert-update image and into this Ansible role. This ensures that the necessary configuration to deploy this Docker image is stored with the Ansible role and changes to the configuration will be limited to this repository. With this the image configuration can change and until the Docker configuration in this role is modified it will not impact this role's usage.
mcdonnnj
force-pushed
the
improvement/rework_functionality
branch
from
b9fb651 to
42f869d
Compare
Since these are not positional arguments we can sort them to make maintenance easier.
jsf9k
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
I think this makes a lot of sense.
Do you intend to clean up cisagov/client-cert-update as well? At a minimum the Docker composition files there can be removed and/or simplified.
Yep I have a branch with the |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request changes this Ansible role to use a specific
docker-compose.ymlfile configured in this repository instead of relying on thedocker-compose.ymlanddocker-compose.override.ymlfiles currently stored in cisagov/client-cert-update.💭 Motivation and context
The use of this role is to deploy the cisagov/client-cert-update image with a specific Docker Compose configuration. It makes more sense to make the Compose configuration independent of the Docker image's configuration. This means that the image can change significantly without impacting this role or it's deployment until it is updated to use a newer image tag.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist