This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Remove the docker-compose.override.yml file
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality this file provides is being moved into cisagov/ansible-role-client-cert-update since that is where that specific configuration is deployed.
mcdonnnj
added
the
improvement
mcdonnnj
added
the
hacktoberfest-accepted
jsf9k
approved these changes
Oct 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the
docker-compose.override.ymlfile from the repository.💭 Motivation and context
Previously cisagov/ansible-role-client-cert-update relied on pulling down the Docker Compose configuration from this repository. The
docker-compose.override.ymlfile was necessary to provide the specific configuration that we use for this Docker image. However as of cisagov/ansible-role-client-cert-update#8 the appropriate configuration is stored in cisagov/ansible-role-client-cert-update instead. Thus we no longer need to keep any deployment specific configuration in this repository.🧪 Testing
Automated tests pass.
✅ Pre-approval checklist