Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #246

Merged
merged 30 commits into from
Jul 14, 2023
Merged

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Jul 12, 2023

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-python-library.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/pshtt.git pshtt
    cd pshtt
    git remote add skeleton https://github.com/cisagov/skeleton-python-library.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add .pre-commit-config.yaml 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

Remove any of the following that do not apply. If you're unsure about
any of these, don't hesitate to ask. We're here to help!

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All new and existing tests pass.

Note
You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

jasonodoom and others added 25 commits May 5, 2023 14:00
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
The golang/lint tool was archived on May 9th, 2021 and based on
golang/go#38968 no future work is planned. Coupled with the fact that
it is not available from brew we are removing this hook as local
development may be hindered by trying to satisfy running this hook.

Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
Co-authored-by: dav3r <david.redmin@gwe.cisa.dhs.gov>
This is done automatically with the `pre-commit autoupdate` command.
The cache key used relies on the existence of a go.sum file. Since we
have no expectation for Go source code, including that file, and since
we already include the Go cache in our job caching, we can safely
disable caching in the Action.
Bump the version of Go used in our GitHub Actions configuration to the
latest stable Go release.
Lineage pull request for: skeleton
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Jul 12, 2023
@jsf9k jsf9k force-pushed the lineage/skeleton branch from aecdea7 to fe8bad9 Compare July 12, 2023 19:31
jsf9k added 4 commits July 12, 2023 16:14
This must be done because our GitHub Actions build workflow runs under
Python 3.7.  pyupgrade no longer supports Python 3.7 as of version
3.4.0, so we cannot upgrade past the 3.3.2 release:
https://github.com/asottile/pyupgrade/blob/v3.4.0/setup.cfg#L23
If we don't do this then markdownlint interprets them as "bare" URLs,
which it forbids.  It makes sense to put them in backticks anyway.
shellcheck gave a warning on the following line, which helped me
realize the actual problem.
ansible-lint no longer supports Python 3.7 as of version 6.0, so we
cannot upgrade past the 5.4.0 release:
https://github.com/ansible/ansible-lint/releases/tag/v6.0.0

But the 5.4.0 release causes a different failure because the version
of ansible isn't correctly pinned.  The best way forward is to simply
comment out this pre-commit hook until we can move to Python >3.7.
@jsf9k jsf9k marked this pull request as ready for review July 13, 2023 17:17
@jsf9k jsf9k requested a review from a team July 13, 2023 17:17
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k merged commit b8014be into develop Jul 14, 2023
@jsf9k jsf9k deleted the lineage/skeleton branch July 14, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants