Use field value function to get html signature

[eileenmcnaughton]

Overview

Use field value function to get html signature

Before

Enotice when accessing signature_text if not set

After

no notice

Technical Details

The getFieldValue function is used for all other tokens on the contact object and will better access
the right value and return an empty string rather NULL if not set.

I hit this as an enotice writing a test - but it is possibly the cause of this issue
eileenmcnaughton/nz.co.fuzion.civitoken#58 (comment)

hence targetting the rc

The tokens() function does weird things if you pass it NULL

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This seems fine to me

[totten]

The description here seems to focus on describing the code mechanics (eg "Changes code to use a widget to get a gizmo").

This Github page would be the main link for the issue in the 5.45.1 release notes, so it'd be useful to give some general sense of the subsystem/use-case impacted. Like... do I interpret correctly that....

• The general heading/subject could fairly say: "Mail Merge - Fix warnings when processing certain empty tokens" (ie it's a problem that affects any mail-merge use-cases - like CiviMail/PDFs/Receipts)
• You've seen that this patch fixes a warning - and strongly suspect that it also fixes a complex regression (involving some combination of civicrm-core + civitokens + gdpr). It's worth publishing because it's safe and maybe/possibly/probably fixes a regression (but the circumstance of the regression is still a bit too complex/unclear to say positively)...?

[eileenmcnaughton]

@totten yeah - I think it might only fix one token not working properly actually (email_html) or just prevent a notice on it. I couldn't replicate

I think like most bugs in the token code the complex one is that NULL is being passed to $row->format('text/html')->tokens() - but I think it might not be in this place