Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The extension broke some core contact token in CiviCRM 5.43 #58

Open
tblein opened this issue Nov 11, 2021 · 1 comment
Open

The extension broke some core contact token in CiviCRM 5.43 #58

tblein opened this issue Nov 11, 2021 · 1 comment

Comments

@tblein
Copy link

tblein commented Nov 11, 2021

Hello

As reported with the uk.co.vedaconsulting.gdpr extension #2907, nz.co.fuzion.civitoken also prevent the rendering of some core token in CiviCRM 5.43. When deactivating the civitoken extension, the concerned tokens render correctly.

At the moment, I identified the following token to be not correctly rendered:

  • {contact.gender}
  • {contact.first_name}
  • {contact.last_name}

Some other tokens from contact render correctly, such as {contact.display_name}, {contact.phone} {contact.email}. I did not investigate all of them.

Fuzion Tokens 1.8
Civi 5.43.0
Wordpress 5.8.2

@eileenmcnaughton
Copy link
Owner

thanks @tblein - I did have on my radar to do a 5.43 release of this extension

eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this issue Jan 10, 2022
The  function is used for all other tokens on the contact object and will better access
the right value and return an empty string rather NULL if not set.

I hit this as an enotice writing a test - but it is possibly the cause of this issue
eileenmcnaughton/nz.co.fuzion.civitoken#58 (comment)

hence targetting the rc

The tokens() function does weird things if you pass it NULL
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this issue Jan 10, 2022
The  function is used for all other tokens on the contact object and will better access
the right value and return an empty string rather NULL if not set.

I hit this as an enotice writing a test - but it is possibly the cause of this issue
eileenmcnaughton/nz.co.fuzion.civitoken#58 (comment)

hence targetting the rc

The tokens() function does weird things if you pass it NULL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants