Refresh balloon toolbar after change in the editor #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
Dec 15, 2017
| var tests = { | ||
| setUp: function() { | ||
| // In IE8 tests are run in very small window which breaks positioning assertions and tests fails (#1076). | ||
| if ( CKEDITOR.env.ie && CKEDITOR.env.version < 9 ) { |
There was a problem hiding this comment.
This part is done by ignoreUnsupportedEnvironment function that you call at the end of a file.
| assert.ignore(); | ||
| } | ||
| if ( parentFrame ) { | ||
| parentFrame.style.height = '900px'; |
There was a problem hiding this comment.
Do we really need these tricks? I see it's a copy'n'paste from positioning.js, to get around #1076, however I cannot reproduce issue described in this ticket.
| 'test panel refresh position': function( editor, bot ) { | ||
|
|
||
| bot.setData( '<figure class="image"><img src="' + bender.basePath + '/_assets/lena.jpg"></figure>', function() { | ||
| var balloonToolbar = new CKEDITOR.ui.balloonToolbarView( editor, { |
There was a problem hiding this comment.
Wrong indentation after this var.
| editor.widgets.instances[ 0 ].on( 'focus', function( evt ) { | ||
| setTimeout( function() { | ||
| editor.execCommand( 'sideImage', { widget: evt.sender } ); | ||
| }, 5000 ); |
There was a problem hiding this comment.
Can we make it 3 secs? 5 seems like forever :D
There was a problem hiding this comment.
I've made it even 2 seconds ;)
|
I've moved unit test to |
…also causes context manager to be refreshed.
Both resize listeners seem to lay out better. In addition placed the document scroll listener in a single line, as it's not that long.
Tests are not ran on IE8, so there's no need for that.
|
Rebased onto latest master branch. |
mlewand
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Added listener for
changeto balloon toolbar position refresher. The drawback of the current solution is the fact that balloon toolbar withoutundoplugin won't refresh its position dynamically.Closes #1342.