Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh balloon toolbar after change in the editor #1351

Merged
merged 11 commits into from
Dec 19, 2017
Merged

Refresh balloon toolbar after change in the editor #1351

merged 11 commits into from
Dec 19, 2017

Commits on Dec 19, 2017

  1. Added change listener to the Balloon Toolbar, so that content change … 

    …also causes context manager to be refreshed.
    @mlewand
    mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    215d0d4 View commit details
    Browse the repository at this point in the history

  2. Add unit test.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    31f7a75 View commit details
    Browse the repository at this point in the history

  3. Add manual test.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    10d3229 View commit details
    Browse the repository at this point in the history

  4. Extract common listener code.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    b4c6d21 View commit details
    Browse the repository at this point in the history

  5. Update unit test.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    8a3be41 View commit details
    Browse the repository at this point in the history

  6. Adjusted listeners order. 

    Both resize listeners seem to lay out better. In addition placed the document scroll listener in a single line, as it's not that long.
    @mlewand
    mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    2186788 View commit details
    Browse the repository at this point in the history

  7. Shortened waiting time in manual test.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    69d4d1b View commit details
    Browse the repository at this point in the history

  8. Move unit test to positioning.js.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    ad73b14 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary ignore.

    @Comandeer @mlewand
    Comandeer authored and mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    7aca396 View commit details
    Browse the repository at this point in the history

  10. Removed redundant comment. 

    Tests are not ran on IE8, so there's no need for that.
    @mlewand
    mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    64dd244 View commit details
    Browse the repository at this point in the history

  11. Changelog entry.

    @mlewand
    mlewand committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    c2893d0 View commit details
    Browse the repository at this point in the history