Added private scope for loadSVGNavigationIcons method (emoji plugin)

[hub33k]

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

• Unit tests
• Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

• PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

*[#3951](https://github.com/ckeditor/ckeditor4/issues/3951): Added private scope for loadSVGNavigationIcons method (emoji plugin).

What changes did you make?

Added private scope for loadSVGNavigationIcons method (emoji plugin)

Which issues does your PR resolve?

Closes #3951.

[f1ames]

Have you checked if documentation now builds correctly? From what I see there is still a warning about global method during build:

And it is still showed as global, just private one:

Instead of a @private property, you need a correct @member namespace, like for example in codesnippet plugin. Please also check if everythink works fine after the changes by building documentation locally.

[f1ames]

Looking at it again, it seems to be more subtle issue. This method is not exposed anywhere and we just doesn't document such methods usually. One can get EmojiPanel via CKEDITOR.ui.get, but still we don't have any docs for it, so having one method documented doesn't look good.

I would just change the comment from /** to // so it is not parsed/processed by JSDuck during docs building.

[f1ames]

👍

[f1ames]

We'll skip changelog entry here since it's not a bug fix nor an API change.