Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added private scope for loadSVGNavigationIcons method (emoji plugin) #3978

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Added private scope for loadSVGNavigationIcons method (emoji plugin) #3978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions plugins/emoji/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,11 +531,8 @@
} );
},

/**
* To avoid CORS issues due to XML based SVG icons, they should be loaded into panel document.
*
* This method ensures that the icons are loaded locally.
*/
// To avoid CORS issues due to XML based SVG icons, they should be loaded into panel document.
// This method ensures that the icons are loaded locally.
loadSVGNavigationIcons: function() {
if ( !this.editor.plugins.emoji.isSVGSupported() ) {
return;
Expand Down