This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/3: Implemented a keystroke to display the toolbar in a collapsed selection #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests? |
Reinmar
reviewed
Jul 11, 2017
src/balloontoolbareditorui.js
Outdated
| @@ -69,7 +69,13 @@ export default class BalloonToolbarEditorUI { | |||
| origin: editor.editing.view, | |||
| originFocusTracker: this.focusTracker, | |||
| originKeystrokeHandler: editor.keystrokes, | |||
| toolbar: contextualToolbar.toolbarView | |||
| toolbar: contextualToolbar.toolbarView, | |||
| beforeFocus: () => { | |||
There was a problem hiding this comment.
BTW, don't you think that beforeFocus callback doing show() is kinda odd? It's hard to read. I had to look into the code to figure out what's going on here.
There was a problem hiding this comment.
After a couple more minutes this looks reasonable... :D So I'm ok. But beforeFocus() { ... } stays.
Well, this is what happens when you start your job one week and finish the next 😅 |
|
❤️ (maybe except that blur at the end, but that's not a priority now)
|
|
AFAIR this blur is a problem we already know about ckeditor/ckeditor5#353. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Implemented a keystroke to display the toolbar in a collapsed selection. Closes ckeditor/ckeditor5#2344.
Requires ckeditor/ckeditor5-ui#270.