Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/3: Implemented a keystroke to display the toolbar in a collapsed selection #8

Merged
merged 4 commits into from
Jul 20, 2017
Merged

t/3: Implemented a keystroke to display the toolbar in a collapsed selection #8

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5358615
Implemented a keystroke to display the toolbar in a collapsed selection.
oleq Jul 3, 2017
f25ba97
Merge branch 'master' into t/3
oleq Jul 10, 2017
520474b
Code-style: Fixed function declarations BalloonToolbarEditorUI.
oleq Jul 12, 2017
93da561
Tests: Extended tests to include enableToolbarKeyboardFocus() integra…
oleq Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/balloontoolbareditorui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,13 @@ export default class BalloonToolbarEditorUI {
origin: editor.editing.view,
originFocusTracker: this.focusTracker,
originKeystrokeHandler: editor.keystrokes,
toolbar: contextualToolbar.toolbarView
toolbar: contextualToolbar.toolbarView,
beforeFocus: () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeFocus() { ....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, don't you think that beforeFocus callback doing show() is kinda odd? It's hard to read. I had to look into the code to figure out what's going on here.

Copy link
Member

@Reinmar Reinmar Jul 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a couple more minutes this looks reasonable... :D So I'm ok. But beforeFocus() { ... } stays.

return contextualToolbar.show();
},
afterBlur: () => {
contextualToolbar.hide();
}
} );
}

Expand Down